Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider changing test config var name away from 'destructiveAllowed' #39

Closed
trentm opened this issue Oct 7, 2015 · 4 comments
Closed

Comments

@trentm
Copy link
Contributor

trentm commented Oct 7, 2015

It is a bit alarmist. A relavant discussion:

`destructiveAllowed`
meaning you can issue delete calls?

tRent
perhaps a bad name. That's the thing that says it can create and delete resources: instances, images, networks, etc.
we should change the name

angela
haha negative connotations - maybe it’s just me

tRent
the implication are:
- will take longer to run
- will use resources (which could result in cost on a public cloud)
- is deleting things, so has the *potential* to screw up

angela
if it’s false, we are just doing GETs?
@pfmooney
Copy link

pfmooney commented Oct 7, 2015

Perhaps it could related to "dry run"?

@trentm
Copy link
Contributor Author

trentm commented Oct 7, 2015

allowWriteActions ?

@trentm
Copy link
Contributor Author

trentm commented Oct 7, 2015

allTheCRUDThings=true

@bahamas10
Copy link
Contributor

the way I've described it in the tests is "read only" and "read/wirte"... I think "allowWriteActions" would be good

(see https://github.com/joyent/node-triton/blob/master/test/integration/cli-profiles.test.js#L54)

@trentm trentm closed this as completed in 0ee966e Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants