vmadm boot fails "Cannot find disk"

[MerlinDMC]

[root@14-da-e9-ed-e1-8b /]# vmadm boot eb0a6d55-42cb-4e10-9d5f-3fa9361503c5 order=cd,once=d cdrom=/boot.iso,ide
Unable to start VM eb0a6d55-42cb-4e10-9d5f-3fa9361503c5: Cannot find disk: /boot.iso

boot.iso is located at /zones/eb0a6d55-42cb-4e10-9d5f-3fa9361503c5/root/boot.iso

Seems to be broken since the last release.

A first look into the code introduced a new vmobj.zoneroot that seems to be never initialized with any value.

[joshwilsdon]

Daniel, can you confirm that this works if you change vmobj.zoneroot to vmobj.zonepath in /usr/vm/node_modules/VM.js? Sorry about that, I'll fix in our branch and talk to John tomorrow about whether we can get a new release built.

[MerlinDMC]

currently i can't compile SmartOS will try tomorrow if noone else goes for it

but i think it should be vmobj.zonepath + "/root" or just working_dir

[joshwilsdon]

You should be able to test without rebuilding by doing:

cp /usr/vm/node_modules/VM.js /var/tmp/VM.js
chmod 755 /var/tmp/VM.js
mount -F lofs /var/tmp/VM.js /usr/vm/node_modules/VM.js

and then editing the file.

[joshwilsdon]

You are correct (I just confirmed) the fix is to change to:

if (!found && path.existsSync(vmobj.zonepath + '/root/' + disk.path)) {

I've tested this here and committed to our internal repo. I'll ask tomorrow if we can get that bit pushed upstream asap.

[jclulow]

I think it's probably better to use path.join, thus:

if (!found && path.existsSync(path.join(vmobj.zonepath, 'root', disk.path))) {

[joshwilsdon]

Good call. I've done it with path.join now. Thanks!

[JohnSonnenschein]

Pushed to smartos-live. I'll rebuild another iso/usbkey since this is a pretty major bug (makes it hard to provision vms without it)