Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluebird Promise expected by loadGroups #1

Closed
Morgul opened this issue Jan 6, 2019 · 1 comment
Closed

Bluebird Promise expected by loadGroups #1

Morgul opened this issue Jan 6, 2019 · 1 comment
Labels

Comments

@Morgul
Copy link
Member

Morgul commented Jan 6, 2019

A Bluebird promise is expected to be return when you pass a function in to loadGroups, which means it does not work with async/await.

The current work around is to just pass in the results of calling your async function, since trivial perms calls Promise.resolve on anything that is passed in, and not a function, which both resolves async functions, and wraps it in the expected bluebird promise.

Frankly, we need to remove the bluebird dependency now that Promises are standard.

@Morgul Morgul added the bug label Jan 6, 2019
@Morgul
Copy link
Member Author

Morgul commented Feb 23, 2023

This was fixed with 5adeb4b.

@Morgul Morgul closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant