Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more and useful tests of the p4est library #26

Open
3 tasks
sloede opened this issue May 26, 2021 · 1 comment
Open
3 tasks

Add more and useful tests of the p4est library #26

sloede opened this issue May 26, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@sloede
Copy link
Member

sloede commented May 26, 2021

While we already have 100% test coverage, this is only due to the fact that we do not count the Julia-to-C bindings as code (since it is not officially part of this package). However, it would be great to have some more meaningful tests that exercise some functionality of the p4est library. I am thinking about things like

  • Create a non-square mesh
  • Refine locally
  • Rebalance

This way, we could have higher confidence that the core algorithms of the JLL package and the custom builds that we test are working as they should.

@sloede sloede added the enhancement New feature or request label May 26, 2021
@efaulhaber
Copy link
Member

efaulhaber commented May 29, 2021

Now that we had two bugs that required workarounds, we should test these features (JuliaPackaging/Yggdrasil#3095 and JuliaPackaging/Yggdrasil#3106) as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants