Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve new bindings based on Clang.jl #54

Open
5 of 10 tasks
ranocha opened this issue Dec 15, 2022 · 1 comment
Open
5 of 10 tasks

Improve new bindings based on Clang.jl #54

ranocha opened this issue Dec 15, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@ranocha
Copy link
Member

ranocha commented Dec 15, 2022

The first complete version is implemented in #49. Here is a list of improvements left for future PRs:

  • Add more tests for CI
  • Make tests look nicer
    • Right now, defining functions in the @testsets used for @cfunction does not work directly. Thus, we define callback functions before the other code, which is not ideal since it is not really local. Can we improve this, e.g., by writing such @testsets in their own files?
  • Set strict = true in docs/make.jl and make Documenter work again in CI
  • Improve corresponding Trixi.jl parts:
  • Create helper functions in P4est.jl for patterns used often in Trixi.jl
  • More getproperty overloads
    • Right now, we get nice getproperty overloads for some pointer types such as Ptr{p4est_quadrant}. It would be nice to have these overloads also to the basic structs such as p4est etc.
    • Maybe Add implementation for PointerWrappers #58 as an alternative?
  • Create a list of headers we do not wrap at the moment
    • Are they needed, shall we add them?
  • How do we want to generate and store new bindings?
    • Bindings specific to p4est versions in src (as drafted in this PR in db12e75)?
    • Infrastructure to build new bindings as we currently have in dev with documentation how to use this stuff and put in in a file that can be used with locally generated bindings?
    • Describe the process in the docs and test it in CI
  • Handle every remaining comment # TODO: Clang (if any)
  • Get rid of dev/fixes.sh and implement the adaptations in Julia in dev/generator.jl to make everything accessible to people familiar with Julia but not necessarily sed etc.
@ranocha
Copy link
Member Author

ranocha commented Mar 8, 2023

@JoshuaLampert The new version including PointerWrappers should be released soon. Thus, you should be able to start working on the updates to Trixi.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant