You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
More stuff later, e.g., wrap also VTK headers and test output
Make tests look nicer
Right now, defining functions in the @testsets used for @cfunction does not work directly. Thus, we define callback functions before the other code, which is not ideal since it is not really local. Can we improve this, e.g., by writing such @testsets in their own files?
Set strict = true in docs/make.jl and make Documenter work again in CI
Check whether quadrant_obj = unsafe_load(quadrant); quadrant_obj.x has a performance impact and whether we should use something like unsafe_load(quadrant.x) instead, see p4est bindings generated with Clang.jl Trixi.jl#1184
Create helper functions in P4est.jl for patterns used often in Trixi.jl
Right now, we get nice getproperty overloads for some pointer types such as Ptr{p4est_quadrant}. It would be nice to have these overloads also to the basic structs such as p4est etc.
Create a list of headers we do not wrap at the moment
Are they needed, shall we add them?
How do we want to generate and store new bindings?
Bindings specific to p4est versions in src (as drafted in this PR in db12e75)?
Infrastructure to build new bindings as we currently have in dev with documentation how to use this stuff and put in in a file that can be used with locally generated bindings?
Describe the process in the docs and test it in CI
Handle every remaining comment # TODO: Clang (if any)
Get rid of dev/fixes.sh and implement the adaptations in Julia in dev/generator.jl to make everything accessible to people familiar with Julia but not necessarily sed etc.
The text was updated successfully, but these errors were encountered:
@JoshuaLampert The new version including PointerWrappers should be released soon. Thus, you should be able to start working on the updates to Trixi.jl.
The first complete version is implemented in #49. Here is a list of improvements left for future PRs:
p4est
p4est
bindings generated with Clang.jl Trixi.jl#1184@testset
s used for@cfunction
does not work directly. Thus, we define callback functions before the other code, which is not ideal since it is not really local. Can we improve this, e.g., by writing such@testset
s in their own files?strict = true
indocs/make.jl
and make Documenter work again in CIquadrant_obj = unsafe_load(quadrant); quadrant_obj.x
has a performance impact and whether we should use something likeunsafe_load(quadrant.x)
instead, seep4est
bindings generated with Clang.jl Trixi.jl#1184pointer_load(info, sides, elem_count)
inp4est
bindings generated with Clang.jl Trixi.jl#1184 (comment) (which should probably bepointer_load(info, :sides, :elem_count)
or@pointer_load(info, sides, elem_count)
)getproperty
overloadsgetproperty
overloads for some pointer types such asPtr{p4est_quadrant}
. It would be nice to have these overloads also to the basicstruct
s such asp4est
etc.p4est
versions insrc
(as drafted in this PR in db12e75)?dev
with documentation how to use this stuff and put in in a file that can be used with locally generated bindings?# TODO: Clang
(if any)dev/fixes.sh
and implement the adaptations in Julia indev/generator.jl
to make everything accessible to people familiar with Julia but not necessarilysed
etc.The text was updated successfully, but these errors were encountered: