Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxiters in trixi_include is not recognized when given as a kwarg after semicolon #1397

Closed
JoshuaLampert opened this issue Apr 16, 2023 · 2 comments · Fixed by #1407
Closed

maxiters in trixi_include is not recognized when given as a kwarg after semicolon #1397

JoshuaLampert opened this issue Apr 16, 2023 · 2 comments · Fixed by #1407
Assignees
@JoshuaLampert
Labels
bug Something isn't working

Comments

@JoshuaLampert
Copy link
Member

This line doesn't catch the case where maxitersis given to solve as a keyword argument behind the semicolon. The issue came up in #1384 (comment).
@JoshuaLampert JoshuaLampert mentioned this issue Apr 16, 2023
Merged
@JoshuaLampert JoshuaLampert self-assigned this Apr 16, 2023
@ranocha
Copy link
Member

ranocha commented Apr 17, 2023

Thanks for taking care of this. As always, please feel free to ask me if something is unclear.

@ranocha ranocha added the bug Something isn't working label Apr 17, 2023
@ranocha
Copy link
Member

ranocha commented Apr 21, 2023

For reference: The full error message is

  LoadError: syntax: keyword argument "maxiters" repeated in call to "solve" around /home/runner/work/Trixi.jl/Trixi.jl/examples/p4est_2d_dgsem/elixir_euler_forward_step_amr.jl:158

See https://github.com/trixi-framework/Trixi.jl/actions/runs/4713823403/jobs/8359764064#step:7:3786

@ranocha ranocha mentioned this issue Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaLampert JoshuaLampert

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix maxiters detection after semicolon trixi-framework/Trixi.jl
2 participants
@ranocha @JoshuaLampert