Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOF reported (somewhat) misleading (IMO) #1667

Closed
DanielDoehring opened this issue Oct 9, 2023 · 2 comments · Fixed by #1669
Closed

DOF reported (somewhat) misleading (IMO) #1667

DanielDoehring opened this issue Oct 9, 2023 · 2 comments · Fixed by #1669

Comments

@DanielDoehring
Copy link
Contributor

DanielDoehring commented Oct 9, 2023

I think that the current definition (and report) of the DOF is confusing, if not misleading.
I would expect that DOF measures the total number of DG coefficients, i.e., the size of the semidiscretization.
However, as it is currently implement, the DOF per field are reported:

Trixi.jl/src/solvers/dg.jl

Lines 409 to 411 in 00292d1

@inline function ndofs(mesh::MeshesDGSEM, dg::DG, cache)
nelements(cache.elements) * nnodes(dg)^ndims(mesh)
end

I suggest that we either multiply the value DOF with nvariables(equaitons) or write in the report

summary_line(io, "total #DOFs", ndofs(semi))

total #DOFs per field.

@ranocha
Copy link
Member

ranocha commented Oct 10, 2023

As far as I can tell, our current way of reporting the DOF is used quite a lot in the literature. This doesn't mean that adding a hint wouldn't be nice

@andrewwinters5000
Copy link
Member

Yeah, it is relatively standard (at least in the turbulence community) that the reported number of DOFs is given per equation, although I am not opposed to having both reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants