Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subcell limiting support for P4estMesh #1954

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

bennibolm
Copy link
Contributor

@bennibolm bennibolm commented May 24, 2024

This PR includes:

  • Adding P4estMesh elixir "elixir_euler_supersonic_cylinder_sc_subcell.jl" and "elixir_euler_sedov_blast_wave_sc_subcell.jl"
  • Add calc_bounds_twosided_interface and calc_bounds_onesided_interface for P4estMesh
  • Update parameters of get_boundary_outer_state to allow normal directions, inner values (for slip wall), ...
  • Remnant of last PR: Move routine save_bounds_check_errors from subcell_bounds_check_2d.jl to subcell_bounds_check.jl

TODO:

  • Code coverage for two-sided bounds calculations for conservative variables.
  • Does it make sense to add additional elixir (e.g. sedov blast) and test calc_bounds_twosided_boundary for Periodic boundaries.

No support for non-conservative terms implemented yet.

Example: Supersonic cylinder
Local two-sided limiting of density, positivity of pressure and local onesided limiting of entropy (guermond et al)
No AMR. Initial refinement level for given mesh of 3 -> 35904 elements; polynomial degree of 3
rho
alpha

@bennibolm bennibolm added the enhancement New feature or request label May 24, 2024
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 99.55556% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.18%. Comparing base (75d8c67) to head (eadcf6f).

Files Patch % Lines
src/callbacks_stage/subcell_bounds_check.jl 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
+ Coverage   96.16%   96.18%   +0.02%     
==========================================
  Files         460      463       +3     
  Lines       36957    37138     +181     
==========================================
+ Hits        35537    35718     +181     
  Misses       1420     1420              
Flag Coverage Δ
unittests 96.18% <99.56%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bennibolm bennibolm marked this pull request as ready for review May 28, 2024 09:25
@bennibolm bennibolm changed the title WIP: Add subcell limiting support for P4estMesh Add subcell limiting support for P4estMesh May 28, 2024
@bennibolm bennibolm requested a review from amrueda May 28, 2024 09:26
@bennibolm bennibolm requested a review from sloede June 18, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant