Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant rebalancing of P4estMesh #622

Open
efaulhaber opened this issue May 30, 2021 · 1 comment
Open

Remove redundant rebalancing of P4estMesh #622

efaulhaber opened this issue May 30, 2021 · 1 comment
Labels

Comments

@efaulhaber
Copy link
Member

Once cburstedde/p4est#112 is fixed, we should remove redundant calls to p4est_balance like in code like this:

p4est_balance(mesh.p4est, P4EST_CONNECT_FACE, C_NULL)
# Due to a bug in p4est, the forest needs to be rebalanced twice sometimes
# See https://github.com/cburstedde/p4est/issues/112
p4est_balance(mesh.p4est, P4EST_CONNECT_FACE, C_NULL)

@efaulhaber
Copy link
Member Author

See updates in cburstedde/p4est#112 (comment).
It appears that the way we currently set up the connectivity is not supported, and that we should also set up corner connectivity, even though we don't need that for DG.
That should make this double rebalancing redundant.

This is definitely more work on our side, but from these comments, it seems that our current approach might break one day when they start relying more heavily on corner connectivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants