specifying formatting flags in config

[tansaku]

When using reek with something like pronto I'd love for formatting flags like "-U" to be something we could specify in the .reek configuration file - is something like that possible?

[troessner]

Nope, not possible right now unfortunately. However, our configuration handling has been significantly simplified so it should be pretty easy to implement something like that and I also believe that this would be super-helpful.:)

[tansaku]

cool - maybe I should work on this first, before adding the ability to change the descriptors ...

[tansaku]

If I wanted to start on this I guess I just try and get my head round the existing configuration and see if I can some how hook in the CLI options ...

[tansaku]

rubocop supports that already like this:

AllCops:
  DisplayStyleGuide: true

this is the equivalent of their -S flag, which is you guys -U, so I guess what we want is to be able to add something to .reek like:

AllSmells:
  DisplayWikiLinks: true

(although docs are not in the wiki anymore ...)

so I just have to work out which part of the code base the CLI handles that - seems to be in reek/cli/option_interpreter.rb where we end up using the Report::WikiLinkWarningFormatter and the issue seems to be that currently the configuration is all about the smells and the cli is all about initializing the reporter .... so ... the challenge is we need the configuration file loading to take place before the reporter is initialized by the command line options ...

[troessner]

@tansaku i'd then rather merge the options handling completely into AppConfiguration, preferably via composition.

[tansaku]

sounds like a plan ...

[tansaku]

gonna hit the message/internationalization first ...

[troessner]

Cleaning up our issues: This one seems stale. @tansaku feel free to re-open if appropriate.