Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor smell warning to smell detector class mapping #922

Closed
mvz opened this issue May 23, 2016 · 2 comments
Closed

Refactor smell warning to smell detector class mapping #922

mvz opened this issue May 23, 2016 · 2 comments
Labels

Comments

@mvz
Copy link
Collaborator

mvz commented May 23, 2016

Follow-up from #921:

End goal: Do not have both #smell_class and #smell_type instance methods for SmellWarning.

Steps:

  • Allow retrieval of smell detector (class) from smell repository based on smell type string.
  • Use this in TODO file generation.
  • Prepare decoupling of smell detector from smell warning.
  • Deprecate passing of smell detector to smell warning initializer.

Perhaps:

  • Allow re-use of smell repository for all Examiner instances.
@troessner
Copy link
Owner

Sounds good to me!

@mvz
Copy link
Collaborator Author

mvz commented Feb 1, 2020

The #smell_class method is gone now, so apparently this is done.

@mvz mvz closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants