Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-apps/nix: user CXXFLAGS are not respected #26

Closed
0n-s opened this issue Dec 14, 2022 · 5 comments
Closed

sys-apps/nix: user CXXFLAGS are not respected #26

0n-s opened this issue Dec 14, 2022 · 5 comments

Comments

@0n-s
Copy link
Contributor

0n-s commented Dec 14, 2022

sys-apps/nix (tested: 2.12.0) builds without any of the user's CXXFLAGS as specified in /etc/portage/make.conf.

Rather funny because the ebuild's removal of the package's implicit optimization CXXFLAGS results in the package being built without any optimizations because of this bug. Definitely not the worst package that could be hit by this issue, but it's nonetheless amusing.
@trofi
Copy link
Owner

trofi commented Dec 14, 2022

Can you post your build.log and emerge --info? I wonder if it's obvious from the log why flags do not apply.

@trofi
Copy link
Owner

trofi commented Dec 14, 2022

Reproduced locally. Probably came back with NixOS/nix@f5b7991 revert.

@trofi trofi closed this as completed in 099fc54 Dec 14, 2022
@trofi
Copy link
Owner

trofi commented Dec 14, 2022

Give 099fc54 a try. In a light build test it does seem to do the right thing.

@0n-s
Copy link
Contributor Author

0n-s commented Dec 14, 2022

Yup, does the job. Thanks!

@trofi trofi mentioned this issue Dec 17, 2022
Merged
@trofi
Copy link
Owner

trofi commented Dec 17, 2022

Proposed the fix upstream as NixOS/nix#7476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trofi @0n-s