Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Authentication fails when password contains \' #317

Open
pro-sumer opened this issue Jul 29, 2020 · 3 comments
Open

Basic Authentication fails when password contains \' #317

pro-sumer opened this issue Jul 29, 2020 · 3 comments

Comments

@pro-sumer
Copy link

Not sure whether this is considered a user error or another instance of #211, but even when I use quotes (") around my password in the config file, Basic Authentication fails in inadyn 2.7 (on Asuswrt-Merlin) when the password contains \' (yes, my password manager actually generated this unlikely/troublesome combination), which will be converted to ' before encryption. Using \\' instead in the config file seems to work, but is confusing (so I changed my password to "fix" this).

While it may be a user error I submitted it anyway, since it took me quite some time to figure this out (comparing the output of -l debug with the output of a REST client (Paw) and then Base 64 decoding the two different Basic Authentication headers) and I hope we can prevent this for other users (even though the combination is not super likely).

@troglobit
Copy link
Owner

Thank you for your report. How do you propose we handle \ in passwords?

@pro-sumer
Copy link
Author

For passwords I think it would best if all characters between the " quotes are treated as literals: used without any processing.

@troglobit
Copy link
Owner

Reasonable, noted. I'll look into it for the next release (possibly the next release of libConfuse, which we use for In-a-dyn). Thanks for getting back on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants