Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkpath return value inconsistency #7

Closed
jesponde opened this issue Oct 30, 2017 · 1 comment
Closed

mkpath return value inconsistency #7

jesponde opened this issue Oct 30, 2017 · 1 comment

Comments

@jesponde
Copy link

Hi,

The comment explains that -1 is returned on error.
But in this specific case, positive 1 is returned.

libite/makepath.c

Line 38 in 6daebf4

return 1;

IMO, comment is correct or at least aligned with mkdir documentation.
So, the returned value should be -1 on error.

Regards,
@jesponde jesponde changed the title mkpath return value incohenrency mkpath return value incoherency Oct 30, 2017
@jesponde jesponde changed the title mkpath return value incoherency mkpath return value inconsistency Oct 30, 2017
@troglobit
Copy link
Owner

Thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@troglobit @jesponde