Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makepath functions signature #8

Closed
jesponde opened this issue Oct 31, 2017 · 2 comments
Closed

makepath functions signature #8

jesponde opened this issue Oct 31, 2017 · 2 comments

Comments

@jesponde
Copy link

Hi,

First, thanks for the very quick fix on the previous comment!

Back to code :-)

Wouldn'it be better to have const char *dir input parameter for these two functions?

int mkpath(char *dir, mode_t mode)

int makepath(char *dir)

When passing std:string::c_str() for example, it would work without any cast.

Minor remark, this include is useless:

#include "lite.h"

Regards,

@troglobit
Copy link
Owner

troglobit commented Oct 31, 2017

Pull requests are most welcome :)

Also, please open a new issue instead of reusing a closed one.

Edit: sorry, about that last paragraph. I'm blaming the ForkHub app for confusing me 🤦‍♂️

@jesponde
Copy link
Author

jesponde commented Oct 31, 2017

Please, forget the minor remark, I think I understood why it is important to keep "lite.h".
This defines strdupa() between other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants