We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
First, thanks for the very quick fix on the previous comment!
Back to code :-)
Wouldn'it be better to have const char *dir input parameter for these two functions?
libite/makepath.c
Line 32 in be6f276
Line 59 in be6f276
When passing std:string::c_str() for example, it would work without any cast.
Minor remark, this include is useless:
Line 22 in be6f276
Regards,
The text was updated successfully, but these errors were encountered:
Pull requests are most welcome :)
Also, please open a new issue instead of reusing a closed one.
Edit: sorry, about that last paragraph. I'm blaming the ForkHub app for confusing me 🤦♂️
Sorry, something went wrong.
Please, forget the minor remark, I think I understood why it is important to keep "lite.h". This defines strdupa() between other things.
add4d5d
No branches or pull requests
Hi,
First, thanks for the very quick fix on the previous comment!
Back to code :-)
Wouldn'it be better to have const char *dir input parameter for these two functions?
libite/makepath.c
Line 32 in be6f276
libite/makepath.c
Line 59 in be6f276
When passing std:string::c_str() for example, it would work without any cast.
Minor remark, this include is useless:
libite/makepath.c
Line 22 in be6f276
Regards,
The text was updated successfully, but these errors were encountered: