Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate "missing" forecast endpoints, implement proposal status response #74

Closed
Tracked by #73
getorymckeag opened this issue Mar 14, 2024 · 2 comments · Fixed by #80
Closed
Tracked by #73

deprecate "missing" forecast endpoints, implement proposal status response #74

getorymckeag opened this issue Mar 14, 2024 · 2 comments · Fixed by #80
Assignees

Comments

@getorymckeag
Copy link
Contributor

No description provided.

@catkins-miso
Copy link
Contributor

catkins-miso commented Mar 14, 2024

@catkins-miso
Copy link
Contributor

catkins-miso commented Mar 14, 2024

Current plan

  • Remove "missing forecast" endpoints from interop spec
  • Bring back incomplete-facilities and invalid-forecast-submissions in the forecast PATCH response
  • Update the GET /ratings-proposals/forecast to include them as appropriate
  • Ensure 415 Unsupported Media Type is specified (returned when client doesn't send Accept: application/vnd.trolie.rating-forecast-proposal-status.v1+json)
  • Security audit--specifically ensure there's no information disclosure risk associated with submitting a forecast where some of the resource-ids do not belong to the authenticated ratings provider

@caindy caindy self-assigned this Mar 15, 2024
@caindy caindy added this to the Forecast Proposal Spec final milestone Mar 15, 2024
@caindy caindy linked a pull request Mar 15, 2024 that will close this issue
@caindy caindy changed the title Review "missing forecasts" endpoints for alignment / consistency with the rest of forecasting deprecate "missing" forecast endpoints, implement proposal status response Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants