Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getLimitsForecastByPeriod? #88

Closed
caindy opened this issue Mar 22, 2024 · 1 comment · Fixed by #90 or #89
Closed

Remove getLimitsForecastByPeriod? #88

caindy opened this issue Mar 22, 2024 · 1 comment · Fixed by #90 or #89
Assignees
@getorymckeag

Comments

@caindy
Copy link
Contributor

caindy commented Mar 22, 2024 •
edited
Loading

It's probably not an interop use case anyway, but couldn't the same result can be obtained from getLimitsForecastSnapshot by using the params period-end = offset-period-start + 1, right?

image
@caindy caindy changed the title Is getLimitsForecastByPeriod redundant with getLimitsForecastSnapshot + period filters? Remove getLimitsForecastByPeriod? Mar 22, 2024
@caindy caindy mentioned this issue Mar 22, 2024
Merged
@getorymckeag
Copy link
Contributor

Yeah not needed for interop, agreed.

@getorymckeag getorymckeag mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getorymckeag getorymckeag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed extraneous limit fetch by period trolie/spec
Remove head trolie/spec
2 participants
@caindy @getorymckeag