Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading notifications when things are happening #26

Open
alastair opened this issue Jul 27, 2021 · 2 comments
Open

Show loading notifications when things are happening #26

alastair opened this issue Jul 27, 2021 · 2 comments

Comments

@alastair
Copy link
Member

When we are loading the score or the annotation there is no indication that we're waiting for something to happen.
There was a "loading" div that we showed and hid, but this isn't a good way to manage the layout of the app using react.
We should look into perhaps creating some hooks that allow us to obtain a loading boolean when while items are still being loaded.

@fedezubo
Copy link
Contributor

I do have a loading spinner available that is animated and looks nice. I think it's called spinner and I was hiding and showing it via queryselector. You can use that if you like :)

@alastair
Copy link
Member Author

I deleted the loading spinner because we shouldn't be modifying the dom directly from react operations. This issue is a reminder to add it back in but use proper react functionality to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants