Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN not working according to the official documentation. #52

Closed
inao-cz opened this issue Dec 29, 2021 · 3 comments
Closed

CDN not working according to the official documentation. #52

inao-cz opened this issue Dec 29, 2021 · 3 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation In development

Comments

@inao-cz
Copy link

inao-cz commented Dec 29, 2021

Describe the bug
Link to CDN used in official documentation is broken thanks to the changed folder structure under dist/

To Reproduce
Steps to reproduce the behavior:
Try to use CDN link. It's unable to fetch (https://cdn.jsdelivr.net/gh/tronic247/material/dist/css/material.min.css)

Expected behavior
Well, obviously it should be fetched from CDN but CDN will return 404

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Can be fixed either by returning the old folder structure or by fixing the link in documentation to https://cdn.jsdelivr.net/gh/tronic247/material/dist/material.min.css - removed /css since folder css doesn't exist.

@Posandu
Copy link
Member

Posandu commented Dec 30, 2021

This issue will be patched soon. Until then here are the links.

JavaScript

https://unpkg.com/tronic247-material@3.0.0/dist/material.min.js

CSS

https://unpkg.com/tronic247-material@3.0.0/dist/material.min.css

And also the documentation is not complete. It will be completed today or tomorrow.

@Posandu Posandu added bug Something isn't working documentation Improvements or additions to documentation In development and removed Issue: Not Seen labels Dec 30, 2021
@Posandu
Copy link
Member

Posandu commented Dec 30, 2021

Fixed

@Posandu Posandu closed this as completed Dec 30, 2021
@jimaek
Copy link

jimaek commented Dec 30, 2021

You use the same format for jsDelivr too https://cdn.jsdelivr.net/npm/tronic247-material@3.0.0/dist/material.min.js

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation In development
Projects
None yet
Development

No branches or pull requests

3 participants