Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify if widgets are resized when calling setGridWidth. #367

Closed
wants to merge 1 commit into from

Conversation

pmoradei
Copy link
Contributor

I added a argument 'doNotPropagate' to the setGridWidth. If this argument is explicitly passed as true the inner widgets will not be resized.

And In the setGridWidth method i also updated the GridstackEngine 'width' attribute in addition to the opts.width. Il you do not do it you will not be able to move/resize widgets to the the new space generated if the parent grid has been expanded.

@radiolips
Copy link
Member

Thanks for the feature/fix, @pmoradei! I think you may have changed the indentation from spacing to tabs. Could you change this back? Unfortunately, the diffs are showing that every single line has been changed.

We are strictly following a particular style guide now. If you do npm install in the gridstack directory you can run jscs gridstack.js. You may need to install jscs globally, not sure. Give that a try and make sure it's passing - As you can see from our automatic TravisCI test, it isn't currently passing. Get these things fixed and I'd love to take a look at your code and hopefully merge it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants