Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter to setGridWidth method to allow not to propagate resi… #371

Merged
merged 2 commits into from
Mar 1, 2016

Conversation

pmoradei
Copy link
Contributor

Add a parameter to setGridWidth method to allow not to propagate resizing to widgets.

I also update the this.grid.width property in the setGridWidth function. If you do not do that the GridStackEngine will not be aware of the new width and you will have 2 problems

  • you will not be able to move widget to the newly created space if the grid has been expanded.
  • you will be able to to move widget beyond the grid's limit if the grid has been shrinked.

@troolee
Copy link
Member

troolee commented Feb 29, 2016

Please update doc file doc/README.md with the new parameter

@pmoradei
Copy link
Contributor Author

pmoradei commented Mar 1, 2016

Done.

@troolee
Copy link
Member

troolee commented Mar 1, 2016

Thanks!

@troolee troolee closed this Mar 1, 2016
@troolee troolee reopened this Mar 1, 2016
troolee added a commit that referenced this pull request Mar 1, 2016
Add a parameter to setGridWidth method to allow not to propagate resi…
@troolee troolee merged commit b3d5be1 into gridstack:master Mar 1, 2016
@pmoradei pmoradei deleted the setgridsize_propagate branch March 1, 2016 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants