some bugs fix include(autoCellHeight,multi grid drag,drag between grid two placeholder) #435
Conversation
Update gridstack.js
2.tow gridstack acceptWidgets bugs fix 3.widget can not resize after drag between two grid bug fix 4.drag between tow grid,two placeholder fix
merge base at 0424
|
Thank you |
|
I've been told that while this PR does fix the issues listed, it causes some other ones. Could anyone elaborate and/or set me straight? A couple parts seem a little iffy in the code, so an explanation would also be great. |
| @@ -800,6 +800,9 @@ | |||
| .removeData('draggable') | |||
| .removeClass('ui-draggable ui-draggable-dragging ui-draggable-disabled') | |||
| .unbind('drag', onDrag); | |||
| if(el.find('div.ui-resizable-handle').length >0){ | |||
| el.find('div.ui-resizable-handle').remove() | |||
There was a problem hiding this comment.
this for me fixes the issue where dragging a griditem to a second grid causes double style preventing resizing of it afterward.
|
Also, please make sure that it passes all tests, including jscs. I see a couple spots in the code that won't match the style, but they're easy fixes. Simply run |
|
note that "4.drag between tow grid,two placeholder fix" doesn't appear anymore in the latest 1.0.0-dev code (using two.html sample code) so not all those fixes are needed. |
|
A few of these have been individually merged. @eagoo , could you split out the remaining fixes into individual PRs and provide jsfiddles or explanations of how to arrive at the issue / solution? Thanks so much! |
|
Hey, guys. Do you have any updates about the issue with duplication? It still reproduces on the latest version here: http://gridstackjs.com/demo/two.html |
1.auto cellHeight fix
2.tow gridstack acceptWidgets bugs fix
3.widget can not resize after drag between two grid bug fix
4.drag between tow grid,two placeholder fix