Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed rounding cellWidth twice #490

Closed
wants to merge 1 commit into from

Conversation

LomoSoftGmbH
Copy link

When using more cols > 12, in my case 40, the doubled rounding forces an unprecise dragging/dropping of widgets

@coveralls
Copy link

coveralls commented Aug 4, 2016

Coverage Status

Coverage decreased (-43.9%) to 28.4% when pulling 0a6bd2c on LomoSoft:cellWidth into 99653bd on troolee:master.

@troolee
Copy link
Member

troolee commented Aug 10, 2016

Hi @LomoSoftGmbH,

thanks for PR, but I didn't get it. Code is the same, you just moved Math.ceil inside the call. Did you want to get smth like:

Math.ceil(cellWidth * (node.minWidth || 1))
..................^^^....................^^^

@radiolips radiolips closed this Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants