Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client to provide HttpClient #27

Closed
smithtj1 opened this issue Mar 21, 2017 · 2 comments
Closed

Allow client to provide HttpClient #27

smithtj1 opened this issue Mar 21, 2017 · 2 comments

Comments

@smithtj1
Copy link
Contributor

smithtj1 commented Mar 21, 2017

I'd like to be able to specify the connection and socket timeouts for the underlying HttpClient used by the Tropo.launchSession(...) methods. Currently they are defaulted to -1 (infinite).

Would it be possible to overload that method to take an HttpClient it can pass to the SessionLauncher that will be used for the connection?

For what its worth, I have some changes of the like on my fork, it could always be abstracted into a generic HttpSettings if you don't want com.voxeo.tropo.Tropo to have knowledge of HttpClient. Let me know if you'd be open to me creating a PR.

Thanks!

@smithtj1 smithtj1 changed the title Allow client to provider HttpClient Allow client to provide HttpClient Mar 21, 2017
@mpermar
Copy link
Contributor

mpermar commented Mar 21, 2017

Hi @smithtj1 . Looks good. I am happy to merge it if you send the PR.

@mpermar
Copy link
Contributor

mpermar commented Mar 21, 2017

Thanks @smithtj1 . Got that one merged and bumped the version on the Maven repo. It'll take a little bit to propagate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants