Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit extension permissions to sites used only #145

Closed
duderin0 opened this issue Jun 30, 2023 · 3 comments
Closed

Limit extension permissions to sites used only #145

duderin0 opened this issue Jun 30, 2023 · 3 comments
Assignees
Labels
bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on

Comments

@duderin0
Copy link

Hi there, on the Firefox extension page (here) under the permissions section, it states the extension needs "Access your data for all websites". Since the extension is only used with a limited number of websites, is there a way the scope could be changed to just those? I've seen other extensions do this, here is one example.

Though if there's some other reason its needed though and can't be changed, maybe for the Sonarr/Radarr integration, this issue can just be closed. Thanks for the work, the extension is pretty handy!

@trossr32 trossr32 self-assigned this Jul 22, 2023
@trossr32 trossr32 added the enhancement New feature or request label Jul 22, 2023
@trossr32
Copy link
Owner

Good idea, will implement in the next release

@trossr32 trossr32 mentioned this issue Jul 22, 2023
@trossr32
Copy link
Owner

Released in v2.8.0

@trossr32
Copy link
Owner

FYI This change is being reverted in v2.8.1. All URLs permission is required because the extension performs the automated search on servarr instances, and this has broken since the release of v2.8.0.

There's no way to know what the URL of anyone's servarr instance would be, so URL limiting is just not possible.

@trossr32 trossr32 added bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on and removed enhancement New feature or request labels Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants