Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beercss #75

Closed
leonardorafael opened this issue Jul 27, 2021 · 3 comments
Closed

Add beercss #75

leonardorafael opened this issue Jul 27, 2021 · 3 comments

Comments

@leonardorafael
Copy link

leonardorafael commented Jul 27, 2021

Trying again 🙃
Can you add beercss project this time?
Github: https://github.com/beercss/beercss
Page: https://www.beercss.com

cover

Thank you!

@laurentpayot
Copy link

laurentpayot commented Jul 29, 2021

➕ 💯 I’m so glad I heard about this project here. Definitively worth adding IMHO…

@troxler
Copy link
Owner

troxler commented Aug 2, 2021

Hi. I had another look:

  • The demo page is still completely unusable if the icon font family fails to load for some reason. They generally also have other problems, e.g. https://cloudfour.com/thinks/seriously-dont-use-icon-fonts/
  • Loading font families from a third-party contradicts "It has zero dependencies."
  • Some components are not accessible using the keyboard, e.g. dropdowns, date pickers, modals, tabs.
  • Inputs in the error state don't have a focus styling.
  • Your demo page has a weird structure. The main heading is using h4, the others use h5. Semantically, that does not make any sense.
  • I realize that you spent a lot of time improving the framework. But judging from Github stars and npm downloads, unfortunately, it still has only a very small reach. Try to make it more popular ;)

@leonardorafael
Copy link
Author

Ok, I'll back another time 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants