Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monaco 0.34.0 does not display emmet expansion preview #107

Closed
CetinSert opened this issue Aug 14, 2022 · 2 comments
Closed

monaco 0.34.0 does not display emmet expansion preview #107

CetinSert opened this issue Aug 14, 2022 · 2 comments

Comments

@CetinSert
Copy link

monaco-0.33.0 + emmet-monaco-es@5.1.2 monaco-0.34.0 + emmet-monaco-es@5.1.2
image image
✔️ present ❌ missing

The expected emmet expansion preview:

<li>|</li>
<li>|</li>

is missing in monaco-0.34.0. How can this be turned back on?

@troy351 troy351 added the bug label Aug 14, 2022
@troy351
Copy link
Owner

troy351 commented Aug 15, 2022

It seems I got the same result for both monaco-editor 0.33.0 and 0.34.0 as your 2nd screenshot and I can't reproduce the 1st one.
image
When you hover on the suggestions, there will be a > on the right side, click it will show the preview as you wanted.
image
monaco itself will somehow remember your preview habit.

FYI. got the same behavior in the latest VSCode

@CetinSert
Copy link
Author

CetinSert commented Aug 15, 2022

@troy351 – Thank you for the very prompt response!

Is there a documented programmatic way of always expending the preview without requiring user interaction?
Otherwise, I will have to mess with the DOM. Anyway, this concludes the issue. Thank you again for looking into it!


Seems like expandSuggestionDocs is missing in 0.34.0.
A hack that I am temporarily using: microsoft/monaco-editor#2241 (comment) simplified to a simple:

editor.getContribution('editor.contrib.suggestController')?.widget?.value?._setDetailsVisible?.(true); // expandSuggestionDocs missing in 0.34.0

@CetinSert CetinSert changed the title monaco 0.34.0 does not display emmet expansion preview monaco 0.34.0 does not display emmet expansion preview Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants