added try/except block to handle authentication errors #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trp07 Added 'raise' statement to try/except block in _get_session method. |
…eally getting back error response. Instead we use mock
trp07
reviewed
Nov 19, 2018
tests/test_email.py
Outdated
| e = get_email | ||
|
|
||
| with pytest.raises(SMTPResponseException): | ||
| print('Exception was not raised, but it should be.') |
trp07
reviewed
Nov 19, 2018
tests/test_email.py
Outdated
| e = get_email | ||
|
|
||
| with pytest.raises(Exception): | ||
| print('Exception was not raised, but it should be.') |
trp07
reviewed
Nov 19, 2018
messages/email_.py
Outdated
| try: | ||
| session.login(self.from_, self._auth) | ||
| except SMTPResponseException as e: | ||
| # decodes bytestring from response to unicode string for readability |
|
Prints removed. |
|
@trp07 Should be good now |
trp07
reviewed
Nov 19, 2018
messages/email_.py
Outdated
| @@ -18,6 +18,7 @@ | |||
| from ._utils import credential_property | |||
| from ._utils import validate_property | |||
| from ._utils import timestamp | |||
| from smtplib import SMTPResponseException | |||
There was a problem hiding this comment.
reorder this to be underneath the "import smtplib" at the top. Typical import hierarchy from top-to-bottom goes: standard library modules, then third-party modules, then internal package modules.
|
@Mat001, thanks a ton for the work. I added a few comments. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trp07 Added try/except block in _get_session() method.
It handles auth errors such as incorrect password.Per: https://docs.python.org/3.6/library/smtplib.html#smtplib.SMTPResponseException