Make v9 support react-query 4?

[KATT]

• react-query@4 is getting released and currently, tRPC doesn't support it. People will be flooding our help channel on Discord soon with issues related to this.
• I don't want us to have pressure to release v10, so I think we should make a minor 9.x-version that has peerDependency of react-query ^4.0.0-.....
• Unsure if we can support both anymore, so we should just say that "after version 9.X.X you have to be on react-query 4"

Partly in progress by @dyaa over in #2240

Things to be done

First release

• Lock current state of tRPC to react-query 3 (lock @trpc/react toreact-query ^3 #2245)

Second release (still on v9.x.x tree!)

• Do something about colliding key context which react-query is introducing?
• Make it work with react-query 4
• Bump peer dependency
• Add warning on some of the React-parts of website

[dyaa]

I'm in favor of releasing react-query@4 after it's being released within the upcoming v10 without pressure where we can address issues of context and other enhancements, wdyt?

[martin-fv]

Is there any info about when react-query releases v4 and how soon will tRPC v10 be realeased?

[mmkal]

Does v10 have to be called "v10"? Could we just support react-query v4 in a smallish breaking change (not working with v3 anymore is very much a breaking change), call that trpc v10 and call the big-architecture-change-project "v11" (or just "vnext" if we don't want to keep assigning and reassigning integers to it before it's ready)?

[KATT]

To be clear - I'm suggesting a breaking change on v9.x. for this.

[jlalmes]

I don't like the idea of breaking changes in non-major versions. I also can't see any fundamental reason to need to support react-query@4 in v9. Should we just support react-query@4 in v10, and leave react-query@3 behind in v9?

v10 is stable(-ish) so if someone is super keen to use react-query@4 just ask them to upgrade tRPC too.

[dyaa]

Adding to @jlalmes and related to

Do something about colliding key context which react-query is introducing?

It looks like there're more breaking changes when it comes to TRPCRequestOptions's context, where we might have to change our property context

[mmkal]

I don't like the idea of breaking changes in non-major versions. I also can't see any fundamental reason to need to support react-query@4 in v9. Should we just support react-query@4 in v10, and leave react-query@3 behind in v9?

v10 is stable(-ish) so if someone is super keen to use react-query@4 just ask them to upgrade tRPC too.

I agree with the first part but stable-ish is pretty different from stable! With discussions like #2131 still open I think it would be a bad idea to suggest anyone move to v10 in production just yet. We should see which is ready first, react-query v4 or trpc vnext. If react-query v4 is ready soon, and trpc vnext turns into The Winds of Winter - I still don't see why we shouldn't bump to v10 with what's currently on main, and start calling the next branch "the next branch" instead of "v10". It seems likely react-query v4 will be out of beta first, because beta > alpha.

[martin-fv]

FYI, react-query just renamed their package to https://www.npmjs.com/package/@tanstack/react-query with an initial version 4.0.5

[KATT]

We've decided not to support react-query 4 for v9 because of the breaking changes it involves.

[github-actions]

This issue has been locked because it had no new activity for 14 days. If you are running into a similar issue, please create a new issue. Thank you.