Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reaction on comments #70

Open
Woitekku opened this issue Nov 28, 2022 · 3 comments
Open

No reaction on comments #70

Woitekku opened this issue Nov 28, 2022 · 3 comments

Comments

@Woitekku
Copy link

Woitekku commented Nov 28, 2022

Hey,

I'm using it with following:

        uses: trstringer/manual-approval@v1
        with:
          secret: ...
          approvers: ...
          minimum-approvals: ...
          issue-title: ...
          exclude-workflow-initiator-as-approver: false

The 1.8.0 version is in use.
Once the issue is raised, and a comment like "approve" is placed, nothing is happening.
There is no another action from bot, that would close the issue and move forward the pipeline, it will stay in waiting for 6hrs.

What is wrong? Is it a bug or am I missing something?

@Woitekku
Copy link
Author

oh i guess i found the issue
exclude-workflow-initiator-as-approver: false

@Woitekku Woitekku reopened this Nov 28, 2022
@Woitekku
Copy link
Author

no; it should be false, as per default to be able to do self-approval...

@trstringer
Copy link
Owner

Can you confirm what the list of approvers are on the actual issue itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants