Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] Add an option to not fail if approvals are not met / timeout #97

Open
gaspo53 opened this issue May 22, 2023 · 1 comment

Comments

@gaspo53
Copy link

gaspo53 commented May 22, 2023

Is it possible to use a flag that makes the process to return the approval status instead of failing? For example, the step will always be success (unless there's a problem with credentials or permissions) and following steps/jobs can check as follows:
if steps.approval.outputs.approved == 'true'

Thanks in advance

@networkhermit
Copy link

networkhermit commented Aug 3, 2023

I upvote for this feature request, as github actions don't support allow-failure in workflow step, nor they have intention to fix it, so when the manual-approval steps failed due to timeout or rejection, the specific workflow run would be marked with failure status and cause annoying notifications both in the ui and email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants