Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update .proto rpc calls / data structures in line with engg codebase #36

Open
arcolife opened this issue Jul 10, 2018 · 2 comments
Open
Assignees
Labels
bug Something isn't working C-level trivial low-level difficulty
Milestone

Comments

@arcolife
Copy link
Collaborator

in line with HybridConsensusHelp.proto from truechain-engineering-code

ref: https://github.com/truechain/truechain-engineering-code/blob/master/eth/truechain/HybridConsensusHelp.proto

@arcolife arcolife added the bug Something isn't working label Jul 10, 2018
@arcolife arcolife added this to the Alpha 1 milestone Jul 10, 2018
@iceming123
Copy link
Contributor

Is it about the RLP encoding the data structure in proto error?

@arcolife
Copy link
Collaborator Author

arcolife commented Jul 23, 2018

@iceming123 tangentially related. One can either use RLPs or protobufs. prysmaticlabs/prysm#150

go-ethereum codebase that you're integrating with mainnet would normally include RLP to talk to each other. but fastchain communicates with snailchain using protobuf.

but this issue right here is about making sure the .proto file we discussed, works for both. currently, it is facilitated to work for core-consensus itself, because of lacking simulations.

@arcolife arcolife added the C-level trivial low-level difficulty label Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C-level trivial low-level difficulty
Projects
None yet
Development

No branches or pull requests

3 participants