Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(home-assistant): Fix invisible items in Automation Dashboard #1163

Merged
merged 3 commits into from Oct 18, 2021
Merged

fix(home-assistant): Fix invisible items in Automation Dashboard #1163

merged 3 commits into from Oct 18, 2021

Conversation

mxyng
Copy link
Contributor

@mxyng mxyng commented Oct 17, 2021

Description

Automations are missing from GUI because configurations.yaml does not include the files Home Assistant references for automations. The same is true for groups, scripts, and scenes. While Home Assistant is able to write to the files, it's not able to read the same files to populate the GUI.

Address issues with #1162 by creating the include files if they do not exist.

Fixes #1161

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Tested by installing chart to local Kubernetes cluster in both clean and upgrade modes.

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

Copy link
Member

@Ornias1993 Ornias1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very clean solution, didn't expect it, much thanks!
Feel free to send your discord nick for the contributor role (+access) on Discord 🥇

@Ornias1993 Ornias1993 merged commit c359221 into truecharts:master Oct 18, 2021
@Ornias1993
Copy link
Member

@all-contributors please add @mxyng for code

@allcontributors
Copy link
Contributor

@Ornias1993

I've put up a pull request to add @mxyng! 🎉

@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[home-assistant] default configuration creates invisible GUI automations
3 participants