Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Apps): Project-Eclipse Part 5, move app-readme to automatic generator #1181

Merged
merged 1 commit into from Oct 19, 2021
Merged

chore(Apps): Project-Eclipse Part 5, move app-readme to automatic generator #1181

merged 1 commit into from Oct 19, 2021

Conversation

Ornias1993
Copy link
Member

@Ornias1993 Ornias1993 commented Oct 19, 2021 •
edited

Description
Having the SCALE specific app-readme.md file in every repo is silly and not needed. This PR moves App readme to an automatic generation script

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@Ornias1993 Ornias1993 added the enhancement New feature or request label Oct 19, 2021
@Ornias1993 Ornias1993 self-assigned this Oct 19, 2021
@Ornias1993 Ornias1993 changed the title chore(Apps): Project-Eclipse 5, move app-readme to automatic generator chore(Apps): Project-Eclipse Part 5, move app-readme to automatic generator Oct 19, 2021
@Ornias1993 Ornias1993 marked this pull request as ready for review October 19, 2021 16:55
@Ornias1993 Ornias1993 merged commit d0630ae into master Oct 19, 2021
@Ornias1993 Ornias1993 deleted the project-eclipse5 branch October 21, 2021 19:56
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ornias1993 Ornias1993

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ornias1993 @truecharts-admin