Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Apps): Project Eclipse Part 6, move questions.yaml to root App folder #1182

Merged
merged 2 commits into from Oct 19, 2021

Conversation

Ornias1993
Copy link
Member

@Ornias1993 Ornias1993 commented Oct 19, 2021

Description
There is just one file remaining in the "SCALE" subfolder, to clean this up we will just move this file (questions.yaml) to the root of the App accordingly.

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:
In the future we might replace this with some different form of generator, but that is considerably more work.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@Ornias1993 Ornias1993 added the enhancement New feature or request label Oct 19, 2021
@Ornias1993 Ornias1993 self-assigned this Oct 19, 2021
@Ornias1993 Ornias1993 changed the title @Ornias1993 refactor(Apps): Project Eclipse Part 6, move questions.yaml to root App folder refactor(Apps): Project Eclipse Part 6, move questions.yaml to root App folder Oct 19, 2021
@Ornias1993 Ornias1993 merged commit b550a06 into master Oct 19, 2021
@Ornias1993 Ornias1993 deleted the project-eclipse6 branch October 21, 2021 19:56
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants