Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jackett): refactor ServiceType to simplify it #1285

Merged
merged 4 commits into from Nov 6, 2021
Merged

chore(jackett): refactor ServiceType to simplify it #1285

merged 4 commits into from Nov 6, 2021

Conversation

Ornias1993
Copy link
Member

@Ornias1993 Ornias1993 commented Nov 6, 2021 •
edited

Description
This PR showcases the required changes for the simplification of the Services GUI.
It also contains a slight improvement (hidden under checkbox) for securityContext and controller sections.

It's aimed to be used as a blueprint for other Apps

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@Ornias1993 Ornias1993 self-assigned this Nov 6, 2021
@Ornias1993 Ornias1993 added the enhancement New feature or request label Nov 6, 2021
@Ornias1993 Ornias1993 added this to the TrueNAS SCALE 22.02 RC2 milestone Nov 6, 2021
@Ornias1993 Ornias1993 changed the title feat(common): Add simple servicetype as a LoadBalancer Alias chore(jackett): refactor ServiceType to simplify it Nov 6, 2021
@Ornias1993 Ornias1993 marked this pull request as ready for review November 6, 2021 11:00
@Ornias1993 Ornias1993 merged commit 4dfe95f into master Nov 6, 2021
@Ornias1993 Ornias1993 deleted the serviceGuiRefactor branch November 28, 2021 14:33
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ornias1993 Ornias1993

Labels
enhancement New feature or request
Projects
None yet
Milestone
TrueNAS SCALE 22.02 RC2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ornias1993 @truecharts-admin