Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps): add a bunch of mariaDB backed Apps #1407

Merged
merged 2 commits into from Nov 30, 2021
Merged

Conversation

Ornias1993
Copy link
Member

@Ornias1993 Ornias1993 commented Nov 25, 2021

Description
This adds another 10 Apps to incubator
Mostly backed by a MariaDB database

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@Ornias1993 Ornias1993 added the enhancement New feature or request label Nov 25, 2021
@Ornias1993 Ornias1993 added this to the TrueNAS SCALE 22.02 RC2 milestone Nov 25, 2021
@Ornias1993 Ornias1993 self-assigned this Nov 25, 2021
@gitguardian
Copy link

gitguardian bot commented Nov 25, 2021

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic Database Assignment d781f91 charts/dev/leantime/values.yaml 21:23 November 25th, 2021 View secret
Generic Database Assignment 051f603 charts/dev/leantime/values.yaml 16:24 November 28th, 2021 View secret
Generic Database Assignment 0c4e896 charts/dev/leantime/values.yaml 16:25 November 28th, 2021 View secret
Generic Database Assignment 6ef711f charts/dev/leantime/values.yaml 16:44 November 28th, 2021 View secret
🛠 How to resolve this
  1. Understand the implications of revoking this secret by examining where it is used in your code.

  2. Replace and store your secret safely. Learn here the best practices

  3. Revoke and rotate this secret

  4. If possible, rewrite your git history to remove all evidence of the secret leak. Please beware this is not a trivial operation. You might completely break other contributing developers’ workflow and you risk accidentally deleting work in progress.

💡 To avoid such incidents in the future, consider following these best practices for managing and storing secrets including API keys and other credentials.

You are seeing this because you or someone else has authorized GitGuardian to scan pull requests

@stavros-k
Copy link
Member

We have a free port in case of conflicts 10058 ;)

@Ornias1993 Ornias1993 force-pushed the mariadb-apps branch 3 times, most recently from 7f3ccdf to bb2861c Compare November 28, 2021 23:00
@Ornias1993 Ornias1993 force-pushed the mariadb-apps branch 2 times, most recently from 2351337 to 58730f3 Compare November 30, 2021 12:52
@Ornias1993 Ornias1993 marked this pull request as ready for review November 30, 2021 12:52
@Ornias1993 Ornias1993 merged commit 90b5511 into master Nov 30, 2021
@Ornias1993 Ornias1993 deleted the mariadb-apps branch December 5, 2021 17:08
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants