Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps): cleanup questions by removing hidden dicts #1558

Merged
merged 16 commits into from Dec 18, 2021

Conversation

stavros-k
Copy link
Member

@stavros-k stavros-k commented Dec 18, 2021

Description

Fixes #

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@stavros-k
Copy link
Member Author

stavros-k commented Dec 18, 2021

  • Remove enabled under persistence AND volumeClaimTemplate from questions.yaml after making sure there are defined in values.yaml
  • Make mountPath editable: false and removed hidden: true , also moved it under # Include{persistenceAdvanced} (in both persistence and volumeClaimTemplate
  • Removed emptyDir persistence from questions.yaml which was already fully hidden (after checking that is defined in values.yaml

@stavros-k stavros-k self-assigned this Dec 18, 2021
@Ornias1993
Copy link
Member

I think it's better to inhide "mountPath" and make it "unwritable" instead...

@stavros-k
Copy link
Member Author

I think it's better to inhide "mountPath" and make it "unwritable" instead...

Hmm, probably yes. so users know where is the actual path inside the container. I'll fix it.

@Ornias1993
Copy link
Member

Don't forget to bump btw, as the questions.yaml test is only run on bump.

@Ornias1993 Ornias1993 marked this pull request as ready for review December 18, 2021 13:54
@Ornias1993 Ornias1993 self-requested a review as a code owner December 18, 2021 13:54
@Ornias1993 Ornias1993 merged commit cf1485a into truecharts:master Dec 18, 2021
@stavros-k stavros-k deleted the cleanup_quest_hiddendict branch December 19, 2021 11:45
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants