Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps): completely remove mountPath reference from GUI #1572

Merged
merged 1 commit into from Dec 19, 2021

Conversation

Ornias1993
Copy link
Member

@Ornias1993 Ornias1993 commented Dec 19, 2021

Description
This removes mountPath from the GUI, which makes it fall back to values.yaml for more consistent behavior.
From a user perspective nothing is changed.

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@Ornias1993 Ornias1993 added bug Something isn't working enhancement New feature or request labels Dec 19, 2021
@Ornias1993 Ornias1993 self-assigned this Dec 19, 2021
@Ornias1993 Ornias1993 added this to the TrueNAS SCALE 22.02 RC2 milestone Dec 19, 2021
@Ornias1993 Ornias1993 merged commit 5092e97 into master Dec 19, 2021
@Ornias1993 Ornias1993 deleted the mountpathremove branch December 21, 2021 20:00
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants