Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guacamole-client): Add guacamole-client #1696

Merged
merged 59 commits into from Jan 14, 2022

Conversation

stavros-k
Copy link
Member

@stavros-k stavros-k commented Jan 12, 2022

Description

Fixes #103

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@stavros-k stavros-k self-assigned this Jan 12, 2022
@stavros-k stavros-k added this to the TrueNAS SCALE 22.02 milestone Jan 12, 2022
@Ornias1993
Copy link
Member

It looks quite decent for a draft wip thingy actually :)

@stavros-k
Copy link
Member Author

stavros-k commented Jan 13, 2022

Ok initContainer 3-temp-hack extracts the files from /opt/guacamole/postgresql from the container into /opt/guacamole/postgresql-hack and downloads the correct driver into the -hack
Then 4-temp-hack copies everything from -hack into a pvc mounted on /opt/guacamole/postgresql which the actual app will use...

I'm pretty sure there is a much simpler way that I cannot see right now :D

@stavros-k
Copy link
Member Author

App should be functional by now.

Tomorrow will look into polishing GUI and adding extensions like TOTP etc

@gitguardian
Copy link

gitguardian bot commented Jan 13, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret aacb5cc charts/incubator/guacamole-client/values.yaml 22:28 January 13th, 2022 View secret
Generic High Entropy Secret 1888a41 charts/incubator/guacamole-client/values.yaml 22:28 January 13th, 2022 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

@Ornias1993
Copy link
Member

@stavros-k I think the radius thing is starting to overcomplicate it a bit.
We barely have a working radius setup anyway.

@stavros-k
Copy link
Member Author

@stavros-k I think the radius thing is starting to overcomplicate it a bit. We barely have a working radius setup anyway.

I'll add it for now, as I'm already on it, and it's easier to fix things up later than add all this bulk.
Good thing is that all modules will be hidden in UI under checkboxes, so it won't add much clutter.

@stavros-k stavros-k marked this pull request as ready for review January 13, 2022 22:14
@Ornias1993 Ornias1993 merged commit b484531 into truecharts:master Jan 14, 2022
@stavros-k stavros-k deleted the guacamole-client branch January 17, 2022 04:45
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ApacheGuacamole
3 participants