Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gui): expose capabilities in GUI #1709

Merged
merged 3 commits into from Jan 13, 2022
Merged

feat(gui): expose capabilities in GUI #1709

merged 3 commits into from Jan 13, 2022

Conversation

Ornias1993
Copy link
Member

@Ornias1993 Ornias1993 commented Jan 13, 2022 •
edited

Description
This addon exposes the capability settings to the Advanced securityContext configuration.
It also moves some more default codesnippets to includes.
Fixes #1197

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@Ornias1993 Ornias1993 added the enhancement New feature or request label Jan 13, 2022
@Ornias1993 Ornias1993 added this to the TrueNAS SCALE 22.02 milestone Jan 13, 2022
@Ornias1993 Ornias1993 self-assigned this Jan 13, 2022
@Ornias1993 Ornias1993 changed the title feat(common): expose capabilities in GUI feat(gui): expose capabilities in GUI Jan 13, 2022
@Ornias1993 Ornias1993 marked this pull request as ready for review January 13, 2022 11:18
@Ornias1993 Ornias1993 merged commit 80039c4 into master Jan 13, 2022
@Ornias1993 Ornias1993 deleted the caps branch February 22, 2022 23:14
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stavros-k stavros-k Awaiting requested review from stavros-k

Assignees

@Ornias1993 Ornias1993

Labels
enhancement New feature or request
Projects
None yet
Milestone
TrueNAS SCALE 22.02
Development

Successfully merging this pull request may close these issues.

Expose capabilities in questions.yaml
2 participants
@Ornias1993 @truecharts-admin