Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Apps): BREAKING CHANGE Move some env-vars outside of env section #2010

Merged
merged 6 commits into from Mar 3, 2022

Conversation

Ornias1993
Copy link
Member

Description
Previous fix for some of the env-vars did not work out nicely, this moves these envs out of the env section.
This might require some users to either reinstall or reconfigure those env settings

It also ensures things like UMASK and PUID are always set and always available for ALL apps

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

@Ornias1993 Ornias1993 added bug Something isn't working enhancement New feature or request labels Mar 3, 2022
@Ornias1993 Ornias1993 self-assigned this Mar 3, 2022
@Ornias1993 Ornias1993 merged commit 4c5c3e5 into master Mar 3, 2022
@Ornias1993 Ornias1993 deleted the PGID-TZ-UMASK branch March 6, 2022 14:05
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants