Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linkding): create initial user #2417

Merged
merged 9 commits into from Apr 3, 2022
Merged

fix(linkding): create initial user #2417

merged 9 commits into from Apr 3, 2022

Conversation

stavros-k
Copy link
Member

@stavros-k stavros-k commented Apr 3, 2022 •
edited

Description

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

@stavros-k stavros-k self-assigned this Apr 3, 2022
@truecharts-admin truecharts-admin added size/M Categorises a PR that changes 30-99 lines, ignoring generated files. precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels Apr 3, 2022
@truecharts-admin truecharts-admin added size/S Categorises a PR that changes 10-29 lines, ignoring generated files. and removed size/M Categorises a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2022
@truecharts-admin truecharts-admin added size/M Categorises a PR that changes 30-99 lines, ignoring generated files. and removed size/S Categorises a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2022
@stavros-k stavros-k marked this pull request as ready for review April 3, 2022 18:07
@stavros-k stavros-k enabled auto-merge (squash) April 3, 2022 18:08
@Ornias1993
Copy link
Member

Ornias1993 commented Apr 3, 2022 •
edited

nvm, is a podstart container. Nice work :)

@Ornias1993 Ornias1993 disabled auto-merge April 3, 2022 18:23
@Ornias1993 Ornias1993 merged commit 5bd7aea into truecharts:master Apr 3, 2022
@stavros-k
Copy link
Member Author

nvm, is a podstart container. Nice work :)

Thanks.
Was trying to use installContainer, but the app has to already run when the command is executed :)

@stavros-k stavros-k deleted the linkding branch April 3, 2022 18:24
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ornias1993 Ornias1993 Ornias1993 approved these changes

Assignees

@stavros-k stavros-k

Labels
install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/M Categorises a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stavros-k @Ornias1993 @truecharts-admin