Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps): revert combine ports #3119

Merged
merged 3 commits into from Jul 10, 2022
Merged

Conversation

stavros-k
Copy link
Member

@stavros-k stavros-k commented Jul 10, 2022

Description

⚒️ Fixes #3117

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

Reverting because the feature flag is not backported to Scale Stable.

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.


Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@truecharts-admin truecharts-admin added the size/L Categorises a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2022
@stavros-k stavros-k changed the title chore(apps): revert combine ports fix(apps): revert combine ports Jul 10, 2022
@stavros-k stavros-k self-assigned this Jul 10, 2022
@stavros-k stavros-k marked this pull request as ready for review July 10, 2022 09:00
@truecharts-admin truecharts-admin added precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful labels Jul 10, 2022
@Ornias1993 Ornias1993 merged commit a4b896d into truecharts:master Jul 10, 2022
@stavros-k stavros-k deleted the revertcombine branch July 10, 2022 09:22
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/L Categorises a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qBittorrent unable to deploy
3 participants