Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress GUI rework #364

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Ingress GUI rework #364

merged 3 commits into from
Apr 15, 2021

Conversation

Ornias1993
Copy link
Member

Description
This PR aim to create a slightly simpler GUI for the Reverse Proxy system
Fixes #

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works

@Ornias1993 Ornias1993 added the enhancement New feature or request label Apr 15, 2021
@Ornias1993 Ornias1993 self-assigned this Apr 15, 2021
@Ornias1993
Copy link
Member Author

The GUI works (get rendered) and the Ingress objects get created.
GOnna merge and away the common-chart update to fix the ingresses again.

This ensures this gets merged before the weekend so we can do the final fixes before 21.04 this weekend.

@Ornias1993 Ornias1993 marked this pull request as ready for review April 15, 2021 21:48
@Ornias1993 Ornias1993 merged commit 5b7f274 into truecharts:master Apr 15, 2021
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants