Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SecurityContext('s) based on PUID and PGID #159

Closed
Ornias1993 opened this issue Feb 20, 2021 · 3 comments
Closed

Set SecurityContext('s) based on PUID and PGID #159

Ornias1993 opened this issue Feb 20, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Ornias1993
Copy link
Member

Is your feature request related to a problem? Please describe.
PUID and PGID work fine for s6_overlay based containers, but not all containers are.
For other we might want to just use SecurityContext instead.

Describe the solution you'd like

  • Set the security contexts based on PUID and PGID.
  • Don't set them when using S6_overlay based containers, set them if we do.
  • Test if we can set fsgroup when running S6_overlay based containers

Describe alternatives you've considered
Leaving it as is or having seperate settings.
The first is sub-optimal, the second is going to get messy and inclear for "the average user"

@Ornias1993 Ornias1993 added the enhancement New feature or request label Feb 20, 2021
@Ornias1993
Copy link
Member Author

Considering this is not a minor patch, it's best suited for next release of TrueNAS SCALE, along with the other refactors.

@Ornias1993
Copy link
Member Author

Done in the staging branch!

@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants