Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki edit option leads to 404 #203

Closed
yorickdowne opened this issue Mar 1, 2021 · 3 comments
Closed

Wiki edit option leads to 404 #203

yorickdowne opened this issue Mar 1, 2021 · 3 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@yorickdowne
Copy link

Describe the bug
The “edit” pencil on the true charts wiki leads to a 404 page.

Example URL: https://github.com/truecharts/charts/edit/master/docs/FAQ.md

Expected behavior
“Edit” on Wiki links to the github repo for the wiki.

@yorickdowne yorickdowne added the bug Something isn't working label Mar 1, 2021
@Ornias1993
Copy link
Member

Ornias1993 commented Mar 1, 2021

The wiki is automatically generated, there is nothing to "edit".
Because the files are in totally different paths than they are on the Wiki, the wiki is never going to have the translation code to translate those Paths. So the Edit button there is never going to work.

However: If you have an idea to disable the edit button i'm open to do so, but afaik thats not possible.
(with "Idea" I mean: an actual PoC based on the software we use to generate the wiki. Not something vague like "edit CSS")

Basically a "won't fix", because it's an upstream design choice and i'm (obviously) not going to build our own mkdocs fork. ;-)

TLDR:
You need to edit it on the main repo, not the wiki.

@Ornias1993 Ornias1993 added the wontfix This will not be worked on label Mar 1, 2021
@Ornias1993
Copy link
Member

@yorickdowne I owe you an apology, I was to quick completely dismissing the issue.
I'm currently working on the wiki and the edit button is already removed! :)

@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants