Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Common] Refactor and Document Ingress #210

Closed
Ornias1993 opened this issue Mar 2, 2021 · 3 comments
Closed

[Common] Refactor and Document Ingress #210

Ornias1993 opened this issue Mar 2, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Ornias1993
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently we have Ingress and appIngress.
Ingress is the Ingress system we ported from upstream when initially creating the common chart
appIngress is our custom ingress system, which provides/adds support for multiple ingress-dicts and ingress types (tcp/udp)

This creates a number of problems:

  1. We also might want a additionalIngress object, which contains a list of ingresses, so users can add unlimited custom ingresses. This would mean we end up with 3(!) ingresses
  2. It creates a hard time getting the Unit-tests to work nicely, so we had to keep the Ingress checks out of the unit-tests for now
  3. It creates more duplicate code than required, which might lead to significant mistakes in the future.

Describe the solution you'd like

  • upstream Ingress is going to be removed
  • appIngress is going to be renamed Ingress
  • additionalIngress is added which can contain a list (but doesn't have to)
  • We need to try if we can create one template for both Ingress and IngressRoute
  • In case we can not (reasonably) create a single template for all ingress forms, we at least need to merge the two IngressRoutes Into one template
  • Create an official standardised questions.yaml format for Ingress and document it
  • Carefully document the ingress (Reverse Proxy) options in the questions.yaml

Describe alternatives you've considered
Leaving it as is.
Which does not solve the problems at all

Additional context

@Ornias1993 Ornias1993 added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 2, 2021
@Ornias1993
Copy link
Member Author

As a big portion of the code resolves around the certificates, we might want to release this rework together with the certificate rework for next release of TrueNAS SCALE

@Ornias1993 Ornias1993 mentioned this issue Mar 3, 2021
10 tasks
@Ornias1993
Copy link
Member Author

Closed, Solved in staging branch

@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants