Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traefik staging not deploying when a cert is selected #289

Closed
piwi3910 opened this issue Apr 5, 2021 · 10 comments
Closed

traefik staging not deploying when a cert is selected #289

piwi3910 opened this issue Apr 5, 2021 · 10 comments
Labels
bug Something isn't working

Comments

@piwi3910
Copy link
Contributor

piwi3910 commented Apr 5, 2021

i can get the deployment to work when i do not select a cert.
but the moment i select any cert i get this:

Error: template: traefik/templates/custom/common.yaml:1:3: executing "traefik/templates/custom/common.yaml" at < include "common.ingress" . >: error calling include: template: traefik/charts/common/templates/_ingress.tpl:26:12: executing "common.ingress" at : error calling include: template: traefik/charts/common/templates/classes/ingress/_ingressRoute.tpl:73:21: executing "common.classes.ingressRoute" at : error calling index: reflect: slice index out of range

this is with a self signed, an imported and/or an acme one.

@piwi3910 piwi3910 added the bug Something isn't working label Apr 5, 2021
@Ornias1993
Copy link
Member

Ornias1993 commented Apr 5, 2021

@piwi3910 Thanks for your bugreport.
Please be aware that ACME certs might also not work at all, Im not sure if that fix is already released in a nightly build

@piwi3910
Copy link
Contributor Author

piwi3910 commented Apr 5, 2021

this error show with an acme cert, an imported non acme cert, and a selfsigned

@Ornias1993
Copy link
Member

Ornias1993 commented Apr 5, 2021

@piwi3910 when did you download your nightly build?
Please be aware that the certificate section is not fully tested yet, as I just today worked on some breaking upstream bugs with iX.

@piwi3910
Copy link
Contributor Author

piwi3910 commented Apr 5, 2021

few hours ago. so it's really latest
TrueNAS-SCALE-21.04-MASTER-20210405-012917

@Ornias1993
Copy link
Member

Ahh awesome, that means the latest certificate fix from this morning is available. :)

@piwi3910
Copy link
Contributor Author

piwi3910 commented Apr 5, 2021

maybe makes sense, that if you have a big PR waiting like this, to keep it in a separate public tree, this way we would be able to test
like "testing"

master (main) would be stable
staging -> testing and validation before going to stable
dev -> latest code use at your own risk.

do you already have a cicd pipeline setup? with some yam linting and stuff?

@Ornias1993
Copy link
Member

@piwi3910
We have a quite complex CI pipeline AND a staging branch, which is quite obviously called staging.

The only reason it exists is because iX systems and I made a LOT of changes to the Apps interface for 21.04. We are (preferably) not going to keep a seperate dev or staging branch in the future. We are going to use "iX Trains system", which was not working till the new Apps UI was merged less than a week ago.

@Ornias1993
Copy link
Member

@piwi3910 Are you sure you added a host to your ingress?
I looked into the code and it looks like you neglected to click the "add" button to actually add a domain to your reverse proxy setup.

there's an open upstream issue with iX to pre-populate the hosts list with a single item, but at least adding one host is (obviously) required.

@Ornias1993
Copy link
Member

I've tested the issue, I can indeed reproduce the correlation between this error and not adding any hosts.
I've added documentation to highlight the fact adding hosts is mandatory.

@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants