Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vikunja config as yaml #4087

Closed
2 tasks done
xeruf opened this issue Oct 13, 2022 · 9 comments · Fixed by #6607
Closed
2 tasks done

Vikunja config as yaml #4087

xeruf opened this issue Oct 13, 2022 · 9 comments · Fixed by #6607
Labels
enhancement New feature or request
Milestone

Comments

@xeruf
Copy link

xeruf commented Oct 13, 2022

Is your feature request related to a problem?

I am migrating Vikunja from k8s-at-home, which had a vikunja.config key for specifying the config as YAML:
https://github.com/k8s-at-home/charts/tree/master/charts/stable/vikunja#values

Looking at your chart, I don't think there is an option for this yet, unless I am misunderstanding the configmap:
https://github.com/truecharts/charts/blob/master/charts/stable/vikunja/values.yaml#L23

Describe the solution you'd like

Implement the config key like it was in k8s-at-home :)

Describe alternatives you've considered

Migrating my config to environment variables, but this is quite a hassle and does not work for the OpenID config.

Additional context

by the way, the links at https://truecharts.org/docs/charts/stable/vikunja/#available-settings are both broken ^^

I've read and agree with the following

  • I've checked all open and closed issues and my request is not there.
  • I've checked all open and closed pull requests and my request is not there.
@xeruf xeruf added the enhancement New feature or request label Oct 13, 2022
@xeruf
Copy link
Author

xeruf commented Oct 13, 2022

Maybe this can just be copied over from https://github.com/k8s-at-home/charts/blob/master/charts/stable/vikunja/templates/configmap.yaml, would be fantastic if you could look into this tomorrow!

I will also make sure to sponsor the great work here when our cashflow stabilizes :)

@Ornias1993
Copy link
Member

Maybe this can just be copied over from https://github.com/k8s-at-home/charts/blob/master/charts/stable/vikunja/templates/configmap.yaml, would be fantastic if you could look into this tomorrow!

I will also make sure to sponsor the great work here when our cashflow stabilizes :)

Please dont pressure people by expecting things “tomorrow”.

this might take months, because its rather low priority to be honest. As it only affects about 1-2% of our users of this App (as it cannot be used on TrueNAS SCALE, which is about 99% of users)

@stavros-k
Copy link
Member

To be honest, Not going to happen any time soon.
As this would be breaking change for at least SCALE users in multiple ways.

But I will surely consider doing this if/when upstream has a breaking change. Which would require users to re-install anyway.

@xeruf
Copy link
Author

xeruf commented Oct 31, 2022

So TrueNAS SCALE users can't use OpenID Connect in Vikunja at the present state?
That's a bummer, as that is exactly what I was planning to do...

@stavros-k
Copy link
Member

So TrueNAS SCALE users can't use OpenID Connect in Vikunja at the present state? That's a bummer, as that is exactly what I was planning to do...

TrueNAS Scale users cannot use yaml config at all. Like there is no freeform editor in the GUI.

So even if this was completed "tomorrow", Scale users still won't have access to values.yaml editor

@xeruf
Copy link
Author

xeruf commented Nov 7, 2022

So unless Vikunja allows configuration of OIDC via env vars, TrueNAS SCALE users can't use OpenID Connect in Vikunja?
Is there not even a safe way to do a manual override?

@stavros-k
Copy link
Member

Override what? As I said, SCALE apps are only configured via GUI. There is no YAML editor there.
Only single line text boxes. We cannot change that, not our design.

Can it happen? Yes.
Will need to template each and every option of the OIDC, and create boxes.

But no, it won't happen soon, at least is not in my plans to do so.
And also doing that, will most likely break things for existing users.

To be clear, it's not a "won't fix".
It's a "not currently"

@xeruf
Copy link
Author

xeruf commented Nov 7, 2022

well, I don't use scale yet, that is why I am asking. I thought there might be a way to push a supplementary configmap via CLI.

@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
4 participants